WebDriver/Meetings/2018-07-30: Difference between revisions
Jump to navigation
Jump to search
(→Status updates: add 1478979) |
(→Moving Selenium Python client to urllib3: fix styling) |
||
(6 intermediate revisions by 3 users not shown) | |||
Line 4: | Line 4: | ||
== Minutes == | == Minutes == | ||
=== Work week === | |||
; dburns | |||
: We could make it pretty much at any time | |||
: If we choose London we can make use the office, and it is easy to travel | |||
: '''ACTION:''' Set up doodle | |||
=== geckodriver availability on wpt.fyi === | |||
We discussed why geckodriver isn’t updated automatically on wpt.fyi. | |||
=== Moving Selenium Python client to urllib3 === | |||
; dburns | |||
: Fixing some test failures, and after that it should be ready to land. | |||
: I also keep hitting different flake8 issues that I can't reproduce. | |||
; whimboo | |||
: Maybe different versions? | |||
; dburns | |||
: Could be. | |||
; ato | |||
: Are you going to release a new version after that? | |||
; dburns | |||
: Possibly. | |||
: I've asked people I know to run their tests with the patch, and things are looking good. | |||
; ato | |||
: It makes geckodriver look bad and we have a hard time communicating that this isn't a geckodriver bug. | |||
: New version would be really good. | |||
; whimboo | |||
: Does all Selenium clients have to make a new release when you ship a new Python client? | |||
; dburns | |||
: No, not for patch/dot releases. | |||
; whimboo | |||
: We have another failure with Windows, with the 10053 socket error. | |||
; ato | |||
: Yes, quite likely this is related. Systems have different networking stacks. | |||
: Let's reassess and see if the client patch fixes the issue. | |||
=== TPAC === | |||
; whimboo | |||
: Do we have to propose discussion items? | |||
; dburns | |||
: Yes, I can create the agenda. | |||
; whimboo | |||
: I have some things to discuss that I want to have done before October. | |||
; ato | |||
: It is a problem that some vendors are unresponsive and that does make it hard to make decisions. | |||
: To not stagnate, we have to make a judgement call in some of these cases. | |||
: “Is this good for the web?” | |||
: jgraham made such a decision about one of jimevans’ PRs last week. | |||
=== Execute Script and user prompts === | |||
; whimboo | |||
: We have a test which has two user prompts in sequence. | |||
: The test expects the first alert to close and to get the return value of the second. | |||
: It is not clear from the WebDriver specification if also the current substep of an algorithm should be aborted when a user prompt appears. | |||
; ato | |||
: It would be problematic to be more specific about ''how'' browser vendors implement this. | |||
: They might use techniques for intercepting the user prompt that are implementation specific. | |||
: Also doing it in the script execution environment using e.g. window.onerror is dangerous because the injected script could remove it. | |||
: The test seems to test the old behaviour of WebDriver, where it would invoke the user prompt handler. | |||
; whimboo | |||
: So the test is wrong? | |||
; ato | |||
: I think so. | |||
; whimboo | |||
: Maybe a good idea to keep the test but change the assertion, so that it is clear we abort after the first of the two alerts? | |||
; ato | |||
: That is a very good idea. | |||
== Status updates == | == Status updates == | ||
Line 15: | Line 87: | ||
** Fixups to mozconfig usability improvement ([https://bugzilla.mozilla.org/show_bug.cgi?id=1476263 1476263]) | ** Fixups to mozconfig usability improvement ([https://bugzilla.mozilla.org/show_bug.cgi?id=1476263 1476263]) | ||
** No significant progress on window tracking | ** No significant progress on window tracking | ||
* Henrik | |||
** '''Investigation of #1 mochitest intermittent failure for hangs of the harness - caused by conversion of the Mochitest extension to a webextension (bug 1414495) | |||
** '''[wdspec] Added tests for user prompt handling for Execute (Async) Script (bug 1439995)''' | |||
** '''[wdspec] Added correctness checks for each command in user prompt tests (bug 1473553)''' | |||
** '''[wpt.fyi] Requested upgrade of geckodriver from 0.19.1 to 0.21.1 - we are shiny green already''' | |||
** [geckodriver] Run all Rust unit tests including webdriver and mozbase crates in TC (bug 1473341) | |||
** [wdspec] Added tests for forward/back/refresh navigation commands (bug 1392274) | |||
** [wdspec] Set default window size of 800x600 for every test (bug 1478368) | |||
* David | |||
** '''Moving Selenium to use urllib3''' | |||
== PTO/travel (🏖) == | == PTO/travel (🏖) == | ||
* Monday | * Monday 27 August is a bank holiday in the UK | ||
* ato away Friday 10 August | * ato away Friday 10 August |
Latest revision as of 15:22, 30 July 2018
Agenda
- Work week
Minutes
Work week
- dburns
- We could make it pretty much at any time
- If we choose London we can make use the office, and it is easy to travel
- ACTION: Set up doodle
geckodriver availability on wpt.fyi
We discussed why geckodriver isn’t updated automatically on wpt.fyi.
Moving Selenium Python client to urllib3
- dburns
- Fixing some test failures, and after that it should be ready to land.
- I also keep hitting different flake8 issues that I can't reproduce.
- whimboo
- Maybe different versions?
- dburns
- Could be.
- ato
- Are you going to release a new version after that?
- dburns
- Possibly.
- I've asked people I know to run their tests with the patch, and things are looking good.
- ato
- It makes geckodriver look bad and we have a hard time communicating that this isn't a geckodriver bug.
- New version would be really good.
- whimboo
- Does all Selenium clients have to make a new release when you ship a new Python client?
- dburns
- No, not for patch/dot releases.
- whimboo
- We have another failure with Windows, with the 10053 socket error.
- ato
- Yes, quite likely this is related. Systems have different networking stacks.
- Let's reassess and see if the client patch fixes the issue.
TPAC
- whimboo
- Do we have to propose discussion items?
- dburns
- Yes, I can create the agenda.
- whimboo
- I have some things to discuss that I want to have done before October.
- ato
- It is a problem that some vendors are unresponsive and that does make it hard to make decisions.
- To not stagnate, we have to make a judgement call in some of these cases.
- “Is this good for the web?”
- jgraham made such a decision about one of jimevans’ PRs last week.
Execute Script and user prompts
- whimboo
- We have a test which has two user prompts in sequence.
- The test expects the first alert to close and to get the return value of the second.
- It is not clear from the WebDriver specification if also the current substep of an algorithm should be aborted when a user prompt appears.
- ato
- It would be problematic to be more specific about how browser vendors implement this.
- They might use techniques for intercepting the user prompt that are implementation specific.
- Also doing it in the script execution environment using e.g. window.onerror is dangerous because the injected script could remove it.
- The test seems to test the old behaviour of WebDriver, where it would invoke the user prompt handler.
- whimboo
- So the test is wrong?
- ato
- I think so.
- whimboo
- Maybe a good idea to keep the test but change the assertion, so that it is clear we abort after the first of the two alerts?
- ato
- That is a very good idea.
Status updates
(Spoken status updates in bold.)
- ato
- Made
session.end()
in WPT WebDriver client swallowSessionNotCreatedError
(1477978) - Made it illegal for
pageLoadStrategy
passed to Marionette to be null (1478979) - Followed up on an old WebDriver spec change to drop the scroll feature from the Take Element Screenshot command (https://github.com/w3c/webdriver/pull/1249)
- Fixups to mozconfig usability improvement (1476263)
- No significant progress on window tracking
- Made
- Henrik
- Investigation of #1 mochitest intermittent failure for hangs of the harness - caused by conversion of the Mochitest extension to a webextension (bug 1414495)
- [wdspec] Added tests for user prompt handling for Execute (Async) Script (bug 1439995)
- [wdspec] Added correctness checks for each command in user prompt tests (bug 1473553)
- [wpt.fyi] Requested upgrade of geckodriver from 0.19.1 to 0.21.1 - we are shiny green already
- [geckodriver] Run all Rust unit tests including webdriver and mozbase crates in TC (bug 1473341)
- [wdspec] Added tests for forward/back/refresh navigation commands (bug 1392274)
- [wdspec] Set default window size of 800x600 for every test (bug 1478368)
- David
- Moving Selenium to use urllib3
PTO/travel (🏖)
- Monday 27 August is a bank holiday in the UK
- ato away Friday 10 August