Firefox/Meeting/06-Jun-2017: Difference between revisions

From MozillaWiki
Jump to navigation Jump to search
(Created page with "To be added. Watch this space.")
 
(Add notes.)
 
Line 1: Line 1:
To be added. Watch this space.
== General Topics / Roundtable ==
 
(tips/tricks/FYI, productivity improvements, industry news)
 
* [MattN] [https://bugzilla.mozilla.org/show_bug.cgi?id=1368699 Bug 1368699 — ./mach build faster doesn't work properly without passing -purgecaches when running Firefox]
 
* [mikedeboer] In fact, [https://bugzilla.mozilla.org/show_bug.cgi?id=1369035 bug 1369035] is about no frontend changes being picked up on artifact builds, unless you do a full ./mach build.
 
* [Evelyn] [https://blog.chromium.org/2017/05/goodbye-pnacl-hello-webassembly.html Google has officially put both NaCl and PNaCl to bed in favor of WebAssembly!]
 
== Friends of the Firefox team ==
 
(Give a shoutout/thanks to people for helping fix and test bugs. Introductions)
 
* Resolved bugs (excluding employees):
 
* More than one bug fixed: [https://mzl.la/2qRLxZ7 https://mzl.la/2qRLxZ7] 
 
* Avikalpa Kundu [:kalpa]
* Dan Banner
* Raajit Raj(:raajitr)
* Santiago Paez [:tiago]
* flyingrub
* tfe
 
* New contributors (🌟 = First Patch!)
 
* 🌟 Alejandro Rodriguez Salamanca [https://bugzilla.mozilla.org/show_bug.cgi?id=1359801 cleaned up] some of our Telemetry code!
* 🌟 junderx [https://bugzilla.mozilla.org/show_bug.cgi?id=1326910 fixed a bug] in how the Page Info dialog reports image dimensions!
* Raajit Raj(:raajitr) [https://bugzilla.mozilla.org/show_bug.cgi?id=1365577 cleaned up a spurious warning] when processing Histograms.json, and also [https://bugzilla.mozilla.org/show_bug.cgi?id=1367750 added some improved strictness] to the Histograms.json schema
* 🌟udara.weera [https://bugzilla.mozilla.org/show_bug.cgi?id=1367525 got rid of some extra error logging] when disconnecting Firefox Account devices!
 
== Project Updates ==
 
=== Add-ons ===
 
* WebExtensions now supports dynamic theming, that will be riding the trains out to release. [https://bugzilla.mozilla.org/show_bug.cgi?id=1341722 https://bugzilla.mozilla.org/show_bug.cgi?id=1341722] see also [https://blog.mozilla.org/addons/2017/02/24/improving-themes-in-firefox/ https://blog.mozilla.org/addons/2017/02/24/improving-themes-in-firefox/] 
* Many performance improvements in WebExtension start up from working with Screenshots team. Most of these have been documented by Ehsan, but check out [https://bugzilla.mozilla.org/show_bug.cgi?id=1363905 https://bugzilla.mozilla.org/show_bug.cgi?id=1363905] for more and...
* Screenshots is now on by default in Firefox 55, meaning that we’ll get to 100% WebExtension coverage for users on release.
* Support for Implement support for $0 and inspect bindings in devtools.inspectedWindow.eval landed in [https://bugzilla.mozilla.org/show_bug.cgi?id=1300590 https://bugzilla.mozilla.org/show_bug.cgi?id=1300590] which means some of the large developer tools add-ons (React, Redux, Ember) etc from Chrome should now be working on Firefox 55 see also: [https://twitter.com/clarkbw/status/870609788366934016 https://twitter.com/clarkbw/status/870609788366934016] 
* devtools.panels.themeName landed [https://bugzilla.mozilla.org/show_bug.cgi?id=1349896 https://bugzilla.mozilla.org/show_bug.cgi?id=1349896]
* Browser_style is now available in browser actions, options UI and the sidebar: [https://bugzilla.mozilla.org/show_bug.cgi?id=1330369 https://bugzilla.mozilla.org/show_bug.cgi?id=1330369]
 
=== Activity Stream ===
 
* [https://mail.mozilla.org/pipermail/firefox-dev/2017-June/005463.html Activity Stream Newsletter] sent to firefox-dev.
 
=== Electrolysis (e10s) ===
 
* [https://wiki.mozilla.org/E10s/Status/June2 Firefox 54 will ship with 4 content processes]. \o/
 
=== [https://wiki.mozilla.org/Firefox_Core_Engineering Firefox Core Engineering] ===
 
* Flash:
 
* Just started week 4 of the Flash Shield Study. Nightly 55 has click-to-activate (CTA) as the default setting. Beta 55 will see a gradual rollout of CTA, though domain blocking will be active for everyone.
 
* Crash:
 
* Startup crashes from BaseThreadInitThunk [https://bugzilla.mozilla.org/show_bug.cgi?id=1322554 has been fixed in 55]. This prevents early DLL injection by third parties in some cases (which is against policy anyway), so check that bug if you’re dealing with an injection-related crash. [This unfortunately does not account for the spike from January to April, so that’s still under investigation.]
* Ping-related analysis is stuck on Symbolication server overload issues. :(
 
=== [https://wiki.mozilla.org/Firefox/Features/Form_Autofill Form Autofill] ===
 
==== Fixed ====
 
* [https://bugzilla.mozilla.org/show_bug.cgi?id=990219 [Form Autofill] Auto-create new profiles based off submitted form data]  
 
* Off by default until the first time use doorhanger is ready
 
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1367297 Helper functions for summarizing field names into groups in FormAutofillUtils.] 
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1349490 Implement the first version of heuristic algorithm.] 
 
* Off by default. Flip extensions.formautofill.heuristics.enabled to try it.
 
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1360370 Field Prediction Heuristics for select element.] 
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1364823 Populate select elements with form autofill profile data] 
 
==== In Progress ====
 
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1300996 Show a preview of what would be filled when a form autofill autocomplete result is highlighted]  
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1364818 [Form Autofill] popup won't apply to an auto-focused input until it's refocused]  
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1365895 When a select element is autofilled, it should fire events properly]  
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1340987 Improve subdialog.js to support multiple dialogs]  
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1365544 Handle filling inexact matches for Form Autofill select elements]  
* [https://bugzilla.mozilla.org/show_bug.cgi?id=556743 Implement the labels attribute]  
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1365489 [Form Autofill] Show select element dropmark in edit profile dialog in preferences]  
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1368008 [Form Autofill] Cache the computed fields in profileStorage]  
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1352324 Store phone numbers in E.164 format]  
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1303510 [Form Autofill] Show a doorhanger to allow opting out of autofill saving when users submit a form for the first time]  
 
=== Lint ===
 
* Don’t forget to install the [https://blog.mozilla.org/standard8/2017/05/04/running-eslint-on-commit-for-mozilla-central-git-mercurial/ ESLint hooks], or [http://eslint.org/docs/user-guide/integrations integrate with your editor]
* [http://eslint.org/docs/rules/no-control-regex No-control-regex] is now enabled across the tree, [https://bugzilla.mozilla.org/show_bug.cgi?id=1370225 mentored] [https://bugzilla.mozilla.org/show_bug.cgi?id=1370232 bugs] posted for [http://eslint.org/docs/rules/comma-style comma-style] and [http://eslint.org/docs/rules/no-unneeded-ternary no-unneeded-ternary]
* Further cleanup of duplicate rules, globals etc is continuing.
* [RyanVM] Proper nodejs/npm support coming soon to MozillaBuild!
 
* Test builds are available [https://bugzilla.mozilla.org/show_bug.cgi?id=1346656#c8 here], but are currently blocked on [https://bugzilla.mozilla.org/show_bug.cgi?id=1342715 bug 1342715].
 
=== Photon ===
 
==== Performance ====
 
* mconley has landed even more tests for sync reflows, [https://bugzilla.mozilla.org/show_bug.cgi?id=1369491 the Photon menu and its subview transitions are now covered], along with window closing, and tab resizing during opening and closing
* We now have [https://bugzilla.mozilla.org/show_bug.cgi?id=1358798 a test checking which JS components and modules are loaded] at which phase of startup, and started [https://bugzilla.mozilla.org/show_bug.cgi?id=1369467 taking things off app-startup].
* Reminder: if you have WIP patches for front-endy things, it’s a good idea to push those to Talos to detect potential regressions early. Feel free to ping mconley if you need help analyzing and dealing with Talos regressions, since he’s currently down there anyways.
 
==== Structure ====
 
* Hamburger panel is now feature-complete! (minor caveat: the library subview is shared with the library button, which is not feature-complete yet)
* Meat ball … I mean, page action menu now has a bookmark item (as well as the synced tabs subview)
 
* Still to come: Pocket & Screenshots
 
* There’s a veeeeery-initial library button + panel available now. Probably not worth testing yet, but available in the palette.
* Sidebar work is still progressing. You can now swap the sidebar to the opposite side of the window, and we’ve done some work on the styling of the sidebar header.
* Greening up tests so we can flip the photon structure pref by default on nightly builds.
 
==== Animation ====
 
* Jared landed [https://bugzilla.mozilla.org/show_bug.cgi?id=1364221 bug 1364221] we now will run more animations on the compositor
* Jared is getting close in bug [https://bugzilla.mozilla.org/show_bug.cgi?id=1355924 1355924] to add an animation for refresh/stop
* Sam is working in [https://bugzilla.mozilla.org/show_bug.cgi?id=1352065 bug 1352065] to implement a new download animation. Some back and forth with UX still to figure out the UX design here.
* Jim is working on a new tab loading indicator in [https://bugzilla.mozilla.org/show_bug.cgi?id=1352119 bug 1352119].
 
==== Visuals ====
 
* Johann added [https://bugzilla.mozilla.org/show_bug.cgi?id=1352358 new compact and touch modes] (that are independent of themes). They can be triggered through setting browser.uidensity to 1 or 2. Setting these will be exposed in the customize mode eventually.
* There is now [https://bugzilla.mozilla.org/show_bug.cgi?id=1355764 less drag space at the top of the tab strip]. It’s in front of the first tab, instead.
* Dao gave the [https://bugzilla.mozilla.org/show_bug.cgi?id=1367384 Windows 10 title bar] a fresh coat of paint.
* Dao also [https://bugzilla.mozilla.org/show_bug.cgi?id=1366424 removed the drop down marker on bookmark toolbar folders] across platforms.
* Nihanth is working on the [https://bugzilla.mozilla.org/show_bug.cgi?id=1367242 new] [https://bugzilla.mozilla.org/show_bug.cgi?id=1355328 sidebar] [https://bugzilla.mozilla.org/show_bug.cgi?id=1355326 styling]
* Dale is working on [https://bugzilla.mozilla.org/show_bug.cgi?id=1363502 updating the identity block design]
 
==== Onboarding ====
 
* [Fischer] Submitted the review request for [https://bugzilla.mozilla.org/show_bug.cgi?id=1369750 bug][https://bugzilla.mozilla.org/show_bug.cgi?id=1369750 1369750] to fix the intermittent issue of accessing the window object inside the onboarding.js framescript.
* [Fischer] Got the review feedbacks from : MattN. [https://bugzilla.mozilla.org/show_bug.cgi?id=1054947 Adding the tests to test touching profiles.ini every 24hrs]
* [Fred] landed the Bug 1361286 [https://bugzilla.mozilla.org/show_bug.cgi?id=1361286 creating the message architecture] so that the Automigration code can talk with Activity Stream
* [Fred] [Rex] Enabled the basic onboarding overlay on [https://bugzilla.mozilla.org/show_bug.cgi?id=1357005 about:newtab] and [https://bugzilla.mozilla.org/show_bug.cgi?id=1369296 about:home]. Now can see a little fox icon on the top-left corner on about:newtab and about:home on Nightly. [https://mozilla.invisionapp.com/share/4MBDUMS5W#/screens/228511972_Overview Here’s the spec.]
* [Rex]  submitted the review request for [https://bugzilla.mozilla.org/show_bug.cgi?id=1357046 Bug 1357046]; this patch will add the Private Browsing tour and the Search tour in the onBoarding overlay
* [Evelyn] Plan is to release the new onboarding flow in 56.
 
==== Preferences ====
 
* [Target 55] Fix P1 bugs of Performance Settings. It is ready for testing.
* [Target 55] Add Performance Settings section into the old organization.
* [Target 55] Update strings of Performance Settings section.
 
* [https://mozilla.invisionapp.com/share/C2B97CAYH#/screens/228017152 Spec]
 
* [Target 56] Enhance search algorithm to highlight the matched result.
 
* Sub-dialog search.
* Fix highlight tooltips bugs.
 
* [Target 56] Updated Preferences Reorg v2 spec (close to be finalized)
 
* [https://mozilla.invisionapp.com/share/P4ACQT1E3#/screens/217167559 Re-org spec]
 
* [Target 56] Lock down Preferences Search spec
 
* [https://mozilla.invisionapp.com/share/ZDAGPK3AF#/screens/218928256 Search spec]
 
=== Platform Audibles ===
 
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1362526 Simplify Page feature in Print Preview] has been enabled by default in Firefox 55 for Windows
* [https://twitter.com/hsinyi71/status/870436875214782464 datetime picker] has been enabled by default on Nightly! Please test and [https://bugzilla.mozilla.org/enter_bug.cgi?assigned_to=nobody%40mozilla.org&bug_file_loc=http%3A%2F%2F&bug_ignored=0&bug_severity=normal&bug_status=NEW&cf_blocking_fennec=---&cf_fx_iteration=---&cf_fx_points=---&cf_platform_rel=---&cf_status_firefox53=---&cf_status_firefox54=---&cf_status_firefox55=---&cf_status_firefox_esr45=---&cf_status_firefox_esr52=---&cf_status_thunderbird_esr45=---&cf_status_thunderbird_esr52=---&cf_tracking_firefox53=---&cf_tracking_firefox54=---&cf_tracking_firefox55=---&cf_tracking_firefox56=---&cf_tracking_firefox57=---&cf_tracking_firefox_esr45=---&cf_tracking_firefox_esr52=---&cf_tracking_firefox_relnote=---&cf_tracking_thunderbird_esr45=---&cf_tracking_thunderbird_esr52=---&component=DOM%3A%20Core%20%26%20HTML&contenttypemethod=autodetect&contenttypeselection=text%2Fplain&defined_groups=1&flag_type-203=X&flag_type-37=X&flag_type-4=X&flag_type-41=X&flag_type-5=X&flag_type-607=X&flag_type-721=X&flag_type-737=X&flag_type-781=X&flag_type-787=X&flag_type-799=X&flag_type-800=X&flag_type-803=X&flag_type-835=X&flag_type-846=X&flag_type-855=X&flag_type-863=X&flag_type-864=X&flag_type-905=X&flag_type-914=X&flag_type-916=X&form_name=enter_bug&maketemplate=Remember%20values%20as%20bookmarkable%20template&op_sys=Unspecified&priority=--&product=Core&rep_platform=Unspecified&target_milestone=---&version=unspecified report bugs].
 
* Big thanks to :jessica and :scottwu for their work here
 
=== Privacy/Security ===
 
* There is a workweek related to ad-blocking happening right now. More details (probably) to come.
 
=== Project Mortar (PDFium) ===
 
* [https://bugzilla.mozilla.org/show_bug.cgi?id=558184 JSPlugin architecture] is now in m-c! (hooray!)
* Given that all facts pointing out Pepper API isn’t future-proof, the team is re-evaluating how to integrate PDFium without Pepper API layer.
 
=== [https://wiki.mozilla.org/Firefox/Search Search] ===
 
* QA for one-off buttons and search suggestions in the Location Bar is ongoing
* Fixed[https://bugzilla.mozilla.org/show_bug.cgi?id=1368477  ][https://bugzilla.mozilla.org/show_bug.cgi?id=1368477 some] [https://bugzilla.mozilla.org/show_bug.cgi?id=1368437 bugs] [https://bugzilla.mozilla.org/show_bug.cgi?id=1367427 found] by QA
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1366426 Some] [https://bugzilla.mozilla.org/show_bug.cgi?id=1303781 misc] [https://bugzilla.mozilla.org/show_bug.cgi?id=1368074 fixes] to the Location Bar and[https://bugzilla.mozilla.org/show_bug.cgi?id=1361322  ][https://bugzilla.mozilla.org/show_bug.cgi?id=1361322 some] [https://bugzilla.mozilla.org/show_bug.cgi?id=1368451 more] [https://bugzilla.mozilla.org/show_bug.cgi?id=1363621 correctness] [https://bugzilla.mozilla.org/show_bug.cgi?id=1337858 fixes] to Favicons
* [https://bugzilla.mozilla.org/show_bug.cgi?id=694291 Preparation] work to run future Unified Location Bar preference-based Shield studies
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1369832 Shipped] a system add-on in release to [https://blog.mozilla.org/data/2017/06/05/measuring-search-in-firefox/ add telemetry] for follow-on searches. [https://bugzilla.mozilla.org/show_bug.cgi?id=1369028 Working] on landing it in m-c, too.
 
=== Sync / Firefox Accounts ===
 
* TPS, the Sync integration test suite, now runs reliably on AWS. :tcsc, :rbillings, and :kthiessen are working on getting TPS to run continuously,
 
* [mikedeboer] Guess what its reports are called… ;-)
 
* :eoger landed improvements to the “send tab to device” experience in Photon.
 
=== [https://wiki.mozilla.org/Test_Pilot Test Pilot] ===
 
* Firefox Screenshots is in Nightly and enabled by default!  Take a shot of something. [https://github.com/mozilla-services/screenshots/issues Report bugs] if you find them please.
 
* Releasing a [https://github.com/mozilla/testpilot/releases/tag/2017-06-01 double big Test Pilot sprint today]
 
== This week I learned ==
 
* [Paolo, RyanVM] Nightly soft freeze in effect! Avoid landing anything considered risky this week.
 
* It’s OK to land patches, but keep in mind that Beta is going to be cut from Nightly next week. There’s no Aurora. Don’t crash land major features.
* If it’s a small patch, or well-tested with thorough QA, you’re good to land.
* Could we have MozReview or Bugzilla remind us when the freeze is in effect? We can also merge Beta early (Wednesday before, instead of Monday).
* Double-check your strings, too.

Latest revision as of 16:36, 12 June 2017

General Topics / Roundtable

(tips/tricks/FYI, productivity improvements, industry news)

  • [mikedeboer] In fact, bug 1369035 is about no frontend changes being picked up on artifact builds, unless you do a full ./mach build.

Friends of the Firefox team

(Give a shoutout/thanks to people for helping fix and test bugs. Introductions)

  • Resolved bugs (excluding employees):
  • Avikalpa Kundu [:kalpa]
  • Dan Banner
  • Raajit Raj(:raajitr)
  • Santiago Paez [:tiago]
  • flyingrub
  • tfe
  • New contributors (🌟 = First Patch!)

Project Updates

Add-ons

Activity Stream

Electrolysis (e10s)

Firefox Core Engineering

  • Flash:
  • Just started week 4 of the Flash Shield Study. Nightly 55 has click-to-activate (CTA) as the default setting. Beta 55 will see a gradual rollout of CTA, though domain blocking will be active for everyone.
  • Crash:
  • Startup crashes from BaseThreadInitThunk has been fixed in 55. This prevents early DLL injection by third parties in some cases (which is against policy anyway), so check that bug if you’re dealing with an injection-related crash. [This unfortunately does not account for the spike from January to April, so that’s still under investigation.]
  • Ping-related analysis is stuck on Symbolication server overload issues. :(

Form Autofill

Fixed

  • [Form Autofill Auto-create new profiles based off submitted form data]  
  • Off by default until the first time use doorhanger is ready
  • Off by default. Flip extensions.formautofill.heuristics.enabled to try it.

In Progress

Lint

Photon

Performance

Structure

  • Hamburger panel is now feature-complete! (minor caveat: the library subview is shared with the library button, which is not feature-complete yet)
  • Meat ball … I mean, page action menu now has a bookmark item (as well as the synced tabs subview)
  • Still to come: Pocket & Screenshots
  • There’s a veeeeery-initial library button + panel available now. Probably not worth testing yet, but available in the palette.
  • Sidebar work is still progressing. You can now swap the sidebar to the opposite side of the window, and we’ve done some work on the styling of the sidebar header.
  • Greening up tests so we can flip the photon structure pref by default on nightly builds.

Animation

  • Jared landed bug 1364221 we now will run more animations on the compositor
  • Jared is getting close in bug 1355924 to add an animation for refresh/stop
  • Sam is working in bug 1352065 to implement a new download animation. Some back and forth with UX still to figure out the UX design here.
  • Jim is working on a new tab loading indicator in bug 1352119.

Visuals

Onboarding

  • [Fischer] Submitted the review request for bug1369750 to fix the intermittent issue of accessing the window object inside the onboarding.js framescript.
  • [Fischer] Got the review feedbacks from : MattN. Adding the tests to test touching profiles.ini every 24hrs
  • [Fred] landed the Bug 1361286 creating the message architecture so that the Automigration code can talk with Activity Stream
  • [Fred] [Rex] Enabled the basic onboarding overlay on about:newtab and about:home. Now can see a little fox icon on the top-left corner on about:newtab and about:home on Nightly. Here’s the spec.
  • [Rex]  submitted the review request for Bug 1357046; this patch will add the Private Browsing tour and the Search tour in the onBoarding overlay
  • [Evelyn] Plan is to release the new onboarding flow in 56.

Preferences

  • [Target 55] Fix P1 bugs of Performance Settings. It is ready for testing.
  • [Target 55] Add Performance Settings section into the old organization.
  • [Target 55] Update strings of Performance Settings section.
  • [Target 56] Enhance search algorithm to highlight the matched result.
  • Sub-dialog search.
  • Fix highlight tooltips bugs.
  • [Target 56] Updated Preferences Reorg v2 spec (close to be finalized)
  • [Target 56] Lock down Preferences Search spec

Platform Audibles

  • Big thanks to :jessica and :scottwu for their work here

Privacy/Security

  • There is a workweek related to ad-blocking happening right now. More details (probably) to come.

Project Mortar (PDFium)

  • JSPlugin architecture is now in m-c! (hooray!)
  • Given that all facts pointing out Pepper API isn’t future-proof, the team is re-evaluating how to integrate PDFium without Pepper API layer.

Search

Sync / Firefox Accounts

  • TPS, the Sync integration test suite, now runs reliably on AWS. :tcsc, :rbillings, and :kthiessen are working on getting TPS to run continuously,
  • [mikedeboer] Guess what its reports are called… ;-)
  • :eoger landed improvements to the “send tab to device” experience in Photon.

Test Pilot

  • Firefox Screenshots is in Nightly and enabled by default!  Take a shot of something. Report bugs if you find them please.

This week I learned

  • [Paolo, RyanVM] Nightly soft freeze in effect! Avoid landing anything considered risky this week.
  • It’s OK to land patches, but keep in mind that Beta is going to be cut from Nightly next week. There’s no Aurora. Don’t crash land major features.
  • If it’s a small patch, or well-tested with thorough QA, you’re good to land.
  • Could we have MozReview or Bugzilla remind us when the freeze is in effect? We can also merge Beta early (Wednesday before, instead of Monday).
  • Double-check your strings, too.
Retrieved from "https://dev.wikimo.nonprod.webservices.mozgcp.net/index.php?title=Firefox/Meeting/06-Jun-2017&oldid=1173238"